Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TS definitions to work correctly on 3rd party repos #190

Merged
merged 2 commits into from
Mar 21, 2017

Conversation

orta
Copy link
Member

@orta orta commented Mar 21, 2017

I was seeing errors around Readonly, and it looks like the declare module part isn't needed for TypeScript.

@orta
Copy link
Member Author

orta commented Mar 21, 2017

screen shot 2017-03-21 at 10 05 14

@DangerCI
Copy link

DangerCI commented Mar 21, 2017

🎉

Generated by 🚫 dangerJS

@codecov-io
Copy link

codecov-io commented Mar 21, 2017

Codecov Report

Merging #190 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #190   +/-   ##
=====================================
  Coverage       0%     0%           
=====================================
  Files           4      4           
  Lines         104    104           
  Branches       16     16           
=====================================
  Misses        104    104

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ce3477...88fd95d. Read the comment docs.

@orta orta merged commit 873d4ca into master Mar 21, 2017
@orta orta deleted the dangerfile_ref branch March 21, 2017 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants