Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail when any types dependency is shipped to library consumers #191

Merged
merged 1 commit into from
Mar 22, 2017

Conversation

orta
Copy link
Member

@orta orta commented Mar 21, 2017

Accidentally shipped @types/chalk with the last release. Not critical, but not good.

Let's ensure it doesn't happen again in the future.

@DangerCI
Copy link

Warnings
⚠️ Changes were made to package.json, but not to yarn.lock.
Perhaps you need to run `yarn install`?

Generated by 🚫 dangerJS

@codecov-io
Copy link

codecov-io commented Mar 21, 2017

Codecov Report

Merging #191 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #191   +/-   ##
=====================================
  Coverage       0%     0%           
=====================================
  Files           4      4           
  Lines         104    104           
  Branches       16     16           
=====================================
  Misses        104    104

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 873d4ca...b5366e0. Read the comment docs.

@orta orta merged commit 7194dbc into master Mar 22, 2017
@orta orta deleted the dev_deps branch March 22, 2017 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants