Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post to the platform when evaling a Dangerfile fails #210

Merged
merged 2 commits into from
Apr 7, 2017
Merged

Conversation

orta
Copy link
Member

@orta orta commented Apr 7, 2017

Fixes #185

@codecov-io
Copy link

codecov-io commented Apr 7, 2017

Codecov Report

Merging #210 into master will increase coverage by 1.45%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #210      +/-   ##
==========================================
+ Coverage   64.76%   66.21%   +1.45%     
==========================================
  Files          32       33       +1     
  Lines         735      743       +8     
  Branches      102      102              
==========================================
+ Hits          476      492      +16     
+ Misses        259      251       -8
Impacted Files Coverage Δ
source/runner/templates/exceptionRaisedTemplate.ts 100% <100%> (ø)
source/runner/Executor.ts 66.17% <100%> (+14.56%) ⬆️
source/platforms/FakePlatform.ts 68.42% <0%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15c48c8...282782f. Read the comment docs.

@@ -15,5 +15,22 @@
},
"files.associations": {
"**/*.js": "javascriptreact"
}
},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my spellchecker got an update

@orta orta merged commit 4b4c8bc into master Apr 7, 2017
@orta orta deleted the post_on_crash branch April 7, 2017 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants