Improve Github dsl test #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
Codecov Report
@@ Coverage Diff @@
## master #214 +/- ##
==========================================
+ Coverage 66.21% 66.75% +0.53%
==========================================
Files 33 33
Lines 743 743
Branches 102 102
==========================================
+ Hits 492 496 +4
+ Misses 251 247 -4
Continue to review full report at Codecov.
|
orta
approved these changes
Apr 12, 2017
| const fixtures = resolve(__dirname, "fixtures") | ||
|
|
||
| /** Returns JSON from the fixtured dir */ | ||
| export const requestWithFixturedJSON = async (path: string): Promise<() => Promise<any>> => () => ( |
There was a problem hiding this comment.
hah, this type annotation at the end! :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improve the way
GitHub.tsis tested by mockingGithubAPIclass so that it is using mock data instead of doing call to API.What do you think about it ? If the approach seems good for you I can write the missing tests, it should be straightforward now to add any test on top of this.