Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests for github.ts #216

Merged
merged 4 commits into from
Apr 13, 2017
Merged

Conversation

alex3165
Copy link
Contributor

No description provided.

@DangerCI
Copy link

DangerCI commented Apr 12, 2017

Warnings
⚠️ Please add a changelog entry for your changes.

Generated by 🚫 dangerJS

@orta
Copy link
Member

orta commented Apr 12, 2017

Yes! Awesome, these CI build failures are real ( it's due to the changes in github_git.ts

@codecov-io
Copy link

codecov-io commented Apr 13, 2017

Codecov Report

Merging #216 into master will increase coverage by 1.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #216      +/-   ##
==========================================
+ Coverage   66.75%   67.78%   +1.02%     
==========================================
  Files          33       33              
  Lines         743      745       +2     
  Branches      102      103       +1     
==========================================
+ Hits          496      505       +9     
+ Misses        247      240       -7
Impacted Files Coverage Δ
source/platforms/github/GitHubGit.ts 98.27% <ø> (+0.06%) ⬆️
source/platforms/GitHub.ts 62.79% <0%> (+16.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9baa8a5...ddb7be1. Read the comment docs.

@alex3165
Copy link
Contributor Author

ah yes I forgot to run all the test, it is fixed now

@orta
Copy link
Member

orta commented Apr 13, 2017

Great - thanks, looks 👍

@orta orta merged commit 9261f42 into danger:master Apr 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants