Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve test failure by lacks of jest #271

Merged
merged 1 commit into from
Jun 8, 2017
Merged

Conversation

kwonoj
Copy link
Member

@kwonoj kwonoj commented Jun 7, 2017

There seems super odd things on certain node.js configuration, jest is not fully installed there. This may be related with some of jest runtime under dependencies, cause I could observe something like below.

npm WARN gentlyRm not removing /home/travis/build/kwonoj/danger-js/node_modules/.bin/jest as it wasn't installed by /home/travis/build/kwonoj/danger-js/node_modules/jest-cli

For a workaround, I made to explicitly install jest after build is done - feel freely to close PR without check in, this is more like fyi.

@kwonoj kwonoj requested a review from orta June 7, 2017 23:26
@DangerCI
Copy link

DangerCI commented Jun 7, 2017

Warnings
⚠️

Please add a changelog entry for your changes.

⚠️

Please add your GitHub name to the changelog entry, so we can attribute you correctly.

Generated by 🚫 dangerJS

@orta
Copy link
Member

orta commented Jun 8, 2017

I'm happy with this 👍

@orta orta merged commit ef8843e into danger:master Jun 8, 2017
@kwonoj kwonoj deleted the test-travis branch June 8, 2017 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants