Adds danger-yarn plugin

[orta]

This is a bit of a dupe right now, as the contents of that plugin came from this dangerfile - but I'm more interested in overall integration. If this works then I'll modify the Dangerfile inside this PR.

[orta]

I feel like there's something uniquely wrong here, maybe it's my plugin? Danger has no problem with other external modules inside the dangerfile.

import * as fs from "fs"
import * as child_process from "child_process"
import fetch from "node-fetch"
import { distanceInWords } from "date-fns"

// For some reason we're getting type errors on this includes module?
// Wonder if we could move to the includes function in ES2015?
import * as includesOriginal from "lodash.includes"

[orta]

It is - lols

[orta]

Just went to check the files:

[orta]

OK, this works, I'm re-writing danger-plugin-yarn now - so may have improvements

[orta]

oh wrong place, this was meant to go danger/generator-danger-plugin#16 - ah well @macklinu will still see it

[DangerCI]

	Warnings
⚠️	New dependencies added: danger-plugin-yarn.

danger-plugin-yarn

Author: Orta Therox

Description: Provides dependency information on dependency changes in a PR

Homepage: https://github.com/orta/danger-plugin-yarn#readme

Created	24 days ago
Last Updated	21 minutes ago
License	MIT
Maintainers	1
Releases	14
Direct Dependencies	date-fns, lodash.flatten, lodash.includes, node-fetch and esdoc
Keywords	danger, danger-plugin and yarn

README

# danger-plugin-yarn

Provides dependency information on dependency changes in a PR

Usage

Install:

yarn add danger-plugin-yarn --dev

At a glance:

// dangerfile.js
import yarn from 'danger-plugin-yarn'

schedule(yarn())

Provides 4 separate rules:

• checkForRelease - Provides a 🎉 when there's a package version bump.
• checkForNewDependencies (async) - Provides npmjs.com and yarn why metadata about new dependencies.
• checkForLockfileDiff - Will warn you when there are dependencies or devDependencies changes without a yarn.lock change.
• checkForTypesInDeps - Will fail the build if you add any @types/[x] to dependencies instead of devDependencies.

And exports a default function to handle all of them at once.

Note: async functions like the default one have be to schedule'd by Danger.

Changelog

See the GitHub release history.

Contributing

See CONTRIBUTING.md.

yarn why danger-plugin-yarn output

• Has been hoisted to "danger-plugin-yarn"
• This module exists because it's specified in "devDependencies".
• Disk size without dependencies: "80kB"
• Disk size with unique dependencies: "3.98MB"
• Disk size with transitive dependencies: "4.43MB"
• Number of shared dependencies: 7

Generated by 🚫 dangerJS

[orta]

Doh - spent all this time thinking things were broken, but really the check only works for dependencies, not devDependencies.

[orta]

this is a weird-ish test, as it's making assertions about how danger-plugin-yarn works, but I'd rather have a test for something, and this seems reasonable enough

[orta]

typos

[orta]

this isn't run by default, but it's nice when you're working on the dangerfile and want to test quickly