Look for more CircleCI PR environment variables #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! |
|
I'll ship this in danger ruby too 👍 |
|
Shipped as 2.0.0-alpha.17 |
|
🎉 Awesome stuff! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues: #326
Circle sometimes does not export a
CI_PULL_REQUESTenvironment variable, but seems to always export aCIRCLE_PULL_REQUESTenvironment variable. They are always exactly the same value.Take a look at these two screenshots. The top one, danger didn't run, the bottom, it did.
This PR adds support for the
CIRCLE_PULL_REQUESTenv var.