Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .jest folder to .npmignore #423

Merged
merged 1 commit into from
Nov 8, 2017
Merged

Add .jest folder to .npmignore #423

merged 1 commit into from
Nov 8, 2017

Conversation

hawkrives
Copy link
Contributor

@hawkrives hawkrives commented Nov 8, 2017

It's around 70mb, and it's currently part of the npm package.

$ npm init -y
$ npm install danger
$ du -hc -d 2 node_modules/danger
  0B	node_modules/danger/node_modules/.bin
 16K	node_modules/danger/distribution/api
 36K	node_modules/danger/types
100K	node_modules/danger/node_modules
100K	node_modules/danger/node_modules/debug
104K	node_modules/danger/distribution/dsl
144K	node_modules/danger/distribution/platforms
148K	node_modules/danger/distribution/commands
180K	node_modules/danger/distribution/runner
204K	node_modules/danger/distribution/ci_source
848K	node_modules/danger/distribution
 75M	node_modules/danger/.jest
 75M	node_modules/danger/.jest/cache
 76M	node_modules/danger
 76M	total

It's ignored by the .gitignore, but IIRC npm ignores the .gitignore completely once you add a .npmignore file.

It's around 65mb, and it's currently part of the npm package
@DangerCI
Copy link

DangerCI commented Nov 8, 2017

Warnings
⚠️

Please add a changelog entry for your changes.

Generated by 🚫 dangerJS

@hawkrives
Copy link
Contributor Author

… Do you want a changelog entry for this change?

@orta
Copy link
Member

orta commented Nov 8, 2017

Nah, I'm fine without it 👍

@orta
Copy link
Member

orta commented Nov 8, 2017

thanks!

@orta orta merged commit 15220c0 into danger:master Nov 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants