Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run the default runner when there are no args (e.g. no calls to the subcommands) #455

Merged
merged 1 commit into from
Dec 28, 2017

Conversation

orta
Copy link
Member

@orta orta commented Dec 24, 2017

I think Danger is always being ran, on every run because it's happening for danger and for danger pr for example.

@DangerCI
Copy link

DangerCI commented Dec 24, 2017

Warnings
⚠️

Expect 2 warnings

⚠️

the other

Generated by 🚫 dangerJS

@orta orta mentioned this pull request Dec 24, 2017
@GantMan
Copy link
Member

GantMan commented Dec 24, 2017

I believe I saw this issue, too. I was able to circumvent it by editing node_modules pull of an what's on NPM.

@orta
Copy link
Member Author

orta commented Dec 24, 2017

Bah, I can't figure this one out - gonna give it tomorrow

@orta orta force-pushed the fix_args branch 2 times, most recently from 7e15b3f to 07897ac Compare December 28, 2017 15:03
@orta orta merged commit c9c06b5 into master Dec 28, 2017
@orta orta deleted the fix_args branch December 28, 2017 15:25
@orta
Copy link
Member Author

orta commented Dec 28, 2017

the warning above come from the last stable release, so fixing the problem here wouldn't actually fix it there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants