Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update madge to the latest version 馃殌 #491

Merged
merged 1 commit into from
Jan 23, 2018
Merged

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Jan 22, 2018

Version 3.0.0 of madge was just published.

Dependency madge
Current Version 2.2.0
Type devDependency

The version 3.0.0 is not covered by your current version range.

If you don鈥檛 accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

It might be worth looking into these changes and trying to get this project onto the latest version of madge.

If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don鈥檛 have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.


Commits

The new version differs by 18 commits.

  • 4edd44a 3.0.0
  • c5cfaa0 Merge pull request #147 from akkumar/dependency_tree_6
  • 806c1ab chore: upgrade dependency-tree to 6.0.0 to address warning
  • 46c8a6d Merge pull request #144 from realityking/dev-deps
  • b184021 Updat eslint to 4.13.0 and @aptoma/eslint-config to 7.0.1.
  • 23d1388 Update should to version 13.1.3
  • 8ee114e Update mocha to version 4.0.1
  • 5d26187 Regenerate package-lock.json
  • aa692f5 Merge pull request #141 from realityking/relative-dependencies
  • 15965a1 Use caret ranges for all dependencies
  • 6f0c6b5 Merge pull request #140 from realityking/chalk
  • 47d2c87 Update chalk to 2.3.0
  • 07e48fb Merge pull request #134 from realityking/update-dependencies
  • 0c6f34f Updates dependencies (not dev-dependencies)
  • c35174c dependency-tree@5.11.1

There are 18 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don鈥檛 help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 馃尨

@DangerCI
Copy link

DangerCI commented Jan 22, 2018

Warnings
鈿狅笍

Please add a changelog entry for your changes. You can find it in CHANGELOG.md

Please add your change and name to the master section.

鈿狅笍

Changes were made to package.json, but not to yarn.lock.
Perhaps you need to run yarn install?

Generated by 馃毇 dangerJS

@orta orta merged commit d89be2a into master Jan 23, 2018
@orta orta deleted the greenkeeper/madge-3.0.0 branch January 23, 2018 15:15
@peril-staging
Copy link
Contributor

peril-staging bot commented Jan 23, 2018

Fails
馃毇

Danger failed to run /app/danger-0.jub68huscth.ts.

Error Error

{"message":"Server Error","documentation_url":"https://developer.github.com/v3/orgs/members/#add-or-update-organization-membership"}
undefined

Dangerfile

// Removed import

declare const peril: any // danger/danger#351
const isJest = typeof jest !== "undefined"

// Stores the parameter in a closure that can be invoked in tests.
const storeRFC = (reason: string, closure: () => void | Promise<any>) =>
  // We return a closure here so that the (promise is resolved|closure is invoked)
  // during test time and not when we call rfc().
  () => (closure instanceof Promise ? closure : Promise.resolve(closure()))

// Either schedules the promise for execution via Danger, or invokes closure.
const runRFC = (reason: string, closure: () => void | Promise<any>) => schedule(closure)

const rfc: any = isJest ? storeRFC : runRFC

rfc("When a PR is merged, check if the author is in the org", async () => {
  const pr = danger.github.pr
  const username = pr.user.login
  const api = danger.github.api

  const org = "danger"
  const inviteMarkdown = `
  Thanks for the PR @${username}.

  We conform to the [Moya Community Continuity Guidelines][moya_cc], which means
  that we want to offer any contributor the ability to control their destiny.
  
  So, we've sent you an org invite - thanks :tada:
  
  [moya_cc]: https://github.com/Moya/contributors#readme
  `

  try {
    await api.orgs.checkMembership({ org, username })
  } catch (error) {
    markdown(inviteMarkdown)
    await api.orgs.addOrgMembership({ org, username, role: "member" })
  }
})

Generated by 馃毇 dangerJS

@peril-staging
Copy link
Contributor

peril-staging bot commented Jan 23, 2018

Thanks for the PR @Greenkeeper[bot].

This PR has been shipped in v3.1.1 - CHANGELOG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants