Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dev] Updates the flow definition, and adds linking it to CI #518

Merged
merged 4 commits into from
Mar 12, 2018

Conversation

orta
Copy link
Member

@orta orta commented Feb 19, 2018

Blocked (ish) by joarwilk/flowgen#30

Updates the flow definitions to Danger so that they pass a flow check, and actually work.

package.json Outdated
@@ -46,7 +46,7 @@
"build": "shx rm -rf ./distribution && tsc -p tsconfig.production.json && madge ./distribution --circular",
"build:fast": "tsc -p tsconfig.production.json",
"build:flow-types":
"cp source/danger.d.ts source/_danger.d.ts; sed -ie 's/api: GitHub/api: any/g' source/_danger.d.ts; npx flowgen source/_danger.d.ts -o distribution/danger.js.flow; node scripts/update_flow_types.js",
"cp source/danger.d.ts source/_danger.d.ts && sed -ie 's/api: GitHub/api: any/g' source/_danger.d.ts && npx -p github:orta/flowgen#union_Strings flowgen source/_danger.d.ts -o distribution/danger.js.flow && node scripts/update_flow_types.js",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cant' figure out how to make npx work with my forked version of flowgen, npx flowgen@orta/flowgen#union_Strings source/_danger.d.ts -o distribution/danger.js.flow was my last attempt

@orta orta force-pushed the more_flow_fixes branch 2 times, most recently from 209994b to abb196c Compare February 19, 2018 17:41
@DangerCI
Copy link

DangerCI commented Feb 19, 2018

New dependencies added: flow-bin.

flow-bin

Author: Sindre Sorhus

Description: Binary wrapper for Flow - A static type checker for JavaScript

Homepage: https://github.com/flowtype/flow-bin#readme

Createdover 3 years ago
Last Updated4 days ago
LicenseMIT
Maintainers9
Releases89
Keywordscli-app, cli, bin, binary, flow, facebook, type, inference, check, checker, javascript, js and wrapper
README

flow-bin Build Status

Binary wrapper for Flow - A static type checker for JavaScript

OS X, Linux (64-bit) and Windows binaries are currently provided.

CLI

$ npm install --global flow-bin
$ flow --help

API

$ npm install --save flow-bin
const execFile = require('child_process').execFile;
const flow = require('flow-bin');

execFile(flow, ['check'], (err, stdout) => {
	console.log(stdout);
});

License

flow-bin is MIT-licensed.

Releases

New Release

  1. Update the "version" in package.json to reflect the flow version to publish. (For now, flow-bin's version is also the version of the flow binary).
  2. Run make.
  • There should be 2 uncommitted changes at this point: SHASUM256.txt and package.json.
  1. Commit the changes with the message Updated binary to v0.30.0, with the correct version.
  2. Push/merge to master.
  3. Tag the update:
git checkout master &&
git pull &&
make test &&
git tag v$(node -p 'require("./package.json").version') &&
git push v$(node -p 'require("./package.json").version')
  1. Publish to npm.

Inspect a Release Before Publishing

npm pack
tar xf "flow-bin-$(node -p 'require("./package.json").version').tgz"
cd package
npm run verify

Generated by 🚫 dangerJS

@orta orta merged commit 798541a into master Mar 12, 2018
@orta orta deleted the more_flow_fixes branch March 12, 2018 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants