-
-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dev] Updates the flow definition, and adds linking it to CI #518
Conversation
16a4d25
to
758384f
Compare
package.json
Outdated
@@ -46,7 +46,7 @@ | |||
"build": "shx rm -rf ./distribution && tsc -p tsconfig.production.json && madge ./distribution --circular", | |||
"build:fast": "tsc -p tsconfig.production.json", | |||
"build:flow-types": | |||
"cp source/danger.d.ts source/_danger.d.ts; sed -ie 's/api: GitHub/api: any/g' source/_danger.d.ts; npx flowgen source/_danger.d.ts -o distribution/danger.js.flow; node scripts/update_flow_types.js", | |||
"cp source/danger.d.ts source/_danger.d.ts && sed -ie 's/api: GitHub/api: any/g' source/_danger.d.ts && npx -p github:orta/flowgen#union_Strings flowgen source/_danger.d.ts -o distribution/danger.js.flow && node scripts/update_flow_types.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cant' figure out how to make npx work with my forked version of flowgen, npx flowgen@orta/flowgen#union_Strings source/_danger.d.ts -o distribution/danger.js.flow
was my last attempt
209994b
to
abb196c
Compare
abb196c
to
052a1ce
Compare
New dependencies added: flow-binAuthor: Sindre Sorhus Description: Binary wrapper for Flow - A static type checker for JavaScript Homepage: https://github.com/flowtype/flow-bin#readme
|
Blocked (ish) by joarwilk/flowgen#30
Updates the flow definitions to Danger so that they pass a
flow check
, and actually work.