Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[inline mode] fix empty comment #564

Merged
merged 4 commits into from
Apr 17, 2018
Merged

[inline mode] fix empty comment #564

merged 4 commits into from
Apr 17, 2018

Conversation

codestergit
Copy link
Contributor

Fixes #563

@codestergit codestergit mentioned this pull request Apr 17, 2018
Merged
8 tasks
orta
orta reviewed Apr 17, 2018
View reviewed changes
source/dsl/DangerResults.ts Outdated
@@ -208,6 +208,10 @@ export function sortResults(results: DangerResults): DangerResults {
}
}

export function isEmpty(results: DangerResults): boolean {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance this could mention results? isEmptyResults? Then this is good to go!

codestergit added a commit to codestergit/danger-js that referenced this pull request Apr 17, 2018
@codestergit
Merge empty comment fix changes pull danger#564
22b4ca0
@orta
Copy link
Member

orta commented Apr 17, 2018

Nice one!

@orta
Copy link
Member

orta commented Apr 17, 2018

Congrats

@orta orta merged commit 5858298 into danger:master Apr 17, 2018
@peril-staging
Copy link
Contributor

peril-staging bot commented Apr 17, 2018

Thanks for the PR @codestergit.

The Danger org conform to the Moya Community Continuity Guidelines, which means
that we want to offer any contributor the ability to control their destiny.

So, we've sent you an org invite - thanks 🎉

Generated by 🚫 dangerJS

@codestergit
Copy link
Contributor Author

codestergit commented Apr 17, 2018 •
edited

Thanks @orta

@peril-staging
Copy link
Contributor

peril-staging bot commented Apr 17, 2018

Thanks for the PR @codestergit.

This PR has been shipped in vv3.5.0 - CHANGELOG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orta orta orta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codestergit @orta