Use pullRequestParser in TeamCity provider
#613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh and btw, should we add info about |
markelog
force-pushed
the
bitbucket
branch
2 times, most recently
from
08c622f
to
48d0298
Compare
If one uses Bitbucket Server + TeamCity, parsing of the PULL_REQUEST_URL environment variable will be incorrect. It seems `pullRequestParser` module already does a pretty good job in figuring out what's what, so use it in TeamCity provider implementation
|
Also added proper handling of |
|
Nice one, yeah, this looks good to me 👍 |
|
Cool thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If one uses Bitbucket Server + TeamCity, parsing of the
PULL_REQUEST_URL environment variable will be incorrect.
It seems
pullRequestParsermodule already does a pretty goodjob in figuring out what's what, so use it in TeamCity provider implementation