Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI integration for Concourse #658

Merged
merged 3 commits into from
Sep 5, 2018
Merged

Add CI integration for Concourse #658

merged 3 commits into from
Sep 5, 2018

Conversation

cwright017
Copy link
Contributor

Adds integration for Concourse CI.

@DangerCI
Copy link

DangerCI commented Sep 4, 2018

Danger run resulted in 1 message; to find out more, see the checks page.

Generated by 🚫 dangerJS

Copy link
Member

@orta orta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - 👍

If you can look at adding the setup notes, then I'm happy to get this shipped

* Concourse CI Integration
*
* https://concourse-ci.org/
*/
Copy link
Member

@orta orta Sep 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all great so far - any chance you can add the full template for setting up concourse here? I've never used it (and so probably can't do good "how to use this" docs ) - the format should look something like this travis or this Surf one. These docs end up on the website being used by anyone wanting to get set up

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, no problem. There are two ways to set this up on Concourse, an easy way ( similar to the rest of the providers ' run yarn danger ci as part of a job ', or make a concourse resource ( a docker container specific to a job that concourse uses ). The latter is the more concourse way to do it, but I first have to create the resource.

My plan was to document the first way, and then amend it to include a reference to the resource once I've created it, is this ok?

@cwright017
Copy link
Contributor Author

Made a comment RE the documentation - #658 (comment)

Posting here as the comment got minimised with the previous change.

@orta
Copy link
Member

orta commented Sep 5, 2018

Awesome, yes!

@orta orta merged commit 8b588d6 into danger:master Sep 5, 2018
@peril-staging
Copy link
Contributor

peril-staging bot commented Sep 5, 2018

Thanks for the PR @cwright017.

The Danger org conform to the Moya Community Continuity Guidelines, which means
that we want to offer any contributor the ability to control their destiny.

So, we've sent you an org invite - thanks Cwright017 🎉

Generated by 🚫 dangerJS

@peril-staging
Copy link
Contributor

peril-staging bot commented Sep 5, 2018

Thanks for the PR @cwright017.

This PR has been shipped in v3.9.0 - CHANGELOG.

@peril-staging
Copy link
Contributor

peril-staging bot commented Sep 13, 2018

Thanks for the PR @cwright017.

This PR has been shipped in v3.8.9 - CHANGELOG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants