Support Multibranch pipelines in Jenkins #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azz
commented
Oct 11, 2018
| return this.env.ghprbGhRepository | ||
| } | ||
|
|
||
| get ciRunURL() { | ||
| return process.env.BUILD_URL | ||
| return process.env.RUN_DISPLAY_URL || process.env.BUILD_URL |
There was a problem hiding this comment.
RUN_DISPLAY_URL is for blue ocean
|
Looks like I ran a newer version of yarn, added |
|
Strange typescript errors only on Node 9? https://travis-ci.org/danger/danger-js/jobs/440092950 |
|
OK, cool, yeah, I'll get this merged and shipped, and the TS error handled too - I know what's going on there. |
|
Thanks for the PR @azz. The Danger org conform to the Moya Community Continuity Guidelines, which means So, we've sent you an org invite - thanks azz 🎉 Generated by 🚫 dangerJS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #379