Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display build status code coverage #70

Merged
merged 3 commits into from
Dec 30, 2016
Merged

Conversation

kwonoj
Copy link
Member

@kwonoj kwonoj commented Dec 30, 2016

This PR is very simple chore, enable codecov code coverage (https://codecov.io) in PR, also display travis build status badge in readme document. I couldn't find appveyor project for its badge.

for code coverage, repo owner need to enable it by visiting codecov.io . long term plan is to use danger itself to give coverage threshold warning.

@orta
Copy link
Member

orta commented Dec 30, 2016

Cool, I can enable this 👍

@orta
Copy link
Member

orta commented Dec 30, 2016

Here's the badge URL: https://www.appveyor.com/docs/status-badges/

@DangerCI
Copy link

DangerCI commented Dec 30, 2016

Warnings
⚠️ Please add a changelog entry for your changes.

Generated by 🚫 dangerJS

@kwonoj
Copy link
Member Author

kwonoj commented Dec 30, 2016

thx, will update shortly.

@codecov-io
Copy link

codecov-io commented Dec 30, 2016

Current coverage is 63.07% (diff: 100%)

No coverage report found for master at 225fc18.

Powered by Codecov. Last update 225fc18...7ba6642

@orta
Copy link
Member

orta commented Dec 30, 2016

[![Build status](https://ci.appveyor.com/api/projects/status/ep5hgeox3lbc5c7f/branch/master?svg=true)](https://ci.appveyor.com/project/orta/danger-js/branch/master)

@orta
Copy link
Member

orta commented Dec 30, 2016

👍 Looks good

@orta orta merged commit 44f0a54 into danger:master Dec 30, 2016
@kwonoj kwonoj deleted the chore-build branch December 30, 2016 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants