Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Danger comment detection #795

Merged
merged 3 commits into from
Dec 26, 2018

Conversation

cysp
Copy link
Member

@cysp cysp commented Dec 26, 2018

The existing fixtures for GitHub API tests don't appear to contain a positive match for this function. Would it be okay to just tweak the existing fixture to include a "Generated by Danger" marker?

@cysp cysp force-pushed the bugfix/githubapi-comment-body-includes branch from 92ab6e1 to 7635f1d Compare December 26, 2018 11:54
source/danger.d.ts Outdated Show resolved Hide resolved
@orta
Copy link
Member

orta commented Dec 26, 2018

Yep, this is what happens when I jump between ruby and JS too much. TypeScript is supposed to fix that! Doh well. Thanks @cysp - I've merged master and the current fail is #794

So I'll merge this and ship it for now.

@orta orta merged commit 2f188ba into danger:master Dec 26, 2018
@cysp cysp deleted the bugfix/githubapi-comment-body-includes branch December 26, 2018 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants