Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare a direct dependency on http-proxy-agent #799

Merged
merged 1 commit into from
Dec 27, 2018

Conversation

cysp
Copy link
Member

@cysp cysp commented Dec 27, 2018

I'm seeing this error when running the latest version of danger-js:

internal/modules/cjs/loader.js:582
    throw err;
    ^

Error: Cannot find module 'http-proxy-agent'

… it looks like we used to get the package via a transitive dependency via @octokit/rest, but that changed with the recent upgrade of that package:
0859032#diff-8ee2343978836a779dc9f8d6b794c3b2L719

@DangerCI
Copy link

Danger run resulted in 2 warnings and 2 markdowns; to find out more, see the checks page.

Generated by 🚫 dangerJS against 5ab78ab

@orta
Copy link
Member

orta commented Dec 27, 2018

Fixes #801

@orta
Copy link
Member

orta commented Dec 27, 2018

Thanks!

@orta orta merged commit 47641fe into danger:master Dec 27, 2018
@peril-staging
Copy link
Contributor

peril-staging bot commented Dec 27, 2018

Thanks for the PR @cysp.

This PR has been shipped in v7.0.1 - CHANGELOG.

@cysp cysp deleted the fix/restore-http-proxy-agent branch December 27, 2018 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants