If DangerID is defined, use it as the context for platform status #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randak
commented
Mar 14, 2019
|
|
||
| let name = "Danger" | ||
| if (process.env["PERIL_INTEGRATION_ID"]) { | ||
| name = "Peril" |
There was a problem hiding this comment.
Do we need to support this use case in Peril? I'm not familiar enough with it to know if it's possible to run multiple instances.
There was a problem hiding this comment.
Nope, or at least whatever we need to do it'd be a bit of work on Perils side 👍
|
@orta Can you take a look at the test failure here? It looks like it might not be related to my changes, but if it is let me know |
orta
approved these changes
Mar 14, 2019
|
|
||
| let name = "Danger" | ||
| if (process.env["PERIL_INTEGRATION_ID"]) { | ||
| name = "Peril" |
There was a problem hiding this comment.
Nope, or at least whatever we need to do it'd be a bit of work on Perils side 👍
|
Awesome, thanks @orta! Any estimate of when this will be published? It'll help us plan whether to go forward with a workaround or wait 😄 |
|
Oh, nevermind, Peril answered me, haha 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #839.
Currently, if you run two separate danger builds with their own IDs, they will post two separate comments. However, the status is not tied to the ID, so if one danger build fails and the second one passes, your PR will incorrectly be marked as passing.
This change uses the ID as the
context/namefor the status, which will allow each build to show up as an independent status, making it possible to have multiple Danger runs on one PR. (We use this to run our build and test in parallel in the CI and report issues from each of them.)