Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ts-jest to 24.0.2 #858

Merged
merged 1 commit into from Apr 13, 2019
Merged

Conversation

friederbluemle
Copy link
Member

This updates ts-jest to 24.0.2, fixing several warnings.

During yarn install phase

warning " > ts-jest@23.10.5" has incorrect peer dependency "jest@>=22 <24".

During yarn test phase

ts-jest[versions] (WARN) Version 24.0.0 of jest installed has not been tested with ts-jest. If you're experiencing issues, consider using a supported version (>=22.0.0 <24.0.0). Please do not report issues in ts-jest if you are using unsupported versions.

@orta
Copy link
Member

orta commented Apr 13, 2019

Thanks!

@orta orta merged commit ed87686 into danger:master Apr 13, 2019
@friederbluemle friederbluemle deleted the update-ts-jest branch April 13, 2019 10:42
@friederbluemle
Copy link
Member Author

@orta - Something odd happened to the master branch in this repo. Looks like some commits were removed:

$ git fetch --all
Fetching origin
From https://github.com/danger/danger-js
 + 93c15cf...b64b42a master     -> origin/master  (forced update)

@orta
Copy link
Member

orta commented Apr 13, 2019

Oh, yeah, good point, I totally just messed up this release - thanks

@friederbluemle
Copy link
Member Author

You can recover the lost commits by force pushing again:

git push -f origin ed87686:master

Then redo the Release 7.1.1 commit.

@friederbluemle
Copy link
Member Author

friederbluemle commented Apr 13, 2019

Right now, 7.1.1 does not have anything except the fixed changelog (b64b42a) compared to 7.1.0.
It's probably best to use a new tag (e.g. 7.1.2) after force pushing

@friederbluemle
Copy link
Member Author

friederbluemle commented Apr 13, 2019

Great, the commits were restored. 👍 I'd suggest you create a new Release 7.1.2 on top of the latest master branch.

@orta
Copy link
Member

orta commented Apr 13, 2019

Thanks @friederbluemle - I've got this

@friederbluemle
Copy link
Member Author

Thanks @orta 👍

@peril-staging
Copy link
Contributor

peril-staging bot commented Apr 13, 2019

Thanks for the PR @friederbluemle.

This PR has been shipped in v7.1.2 - CHANGELOG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants