Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Executor): clarify result message status #90

Merged
merged 1 commit into from
Jan 8, 2017

Conversation

kwonoj
Copy link
Member

@kwonoj kwonoj commented Jan 7, 2017

This PR adds small enhancement to console output, between failure message and non-critical failure messages.

@DangerCI
Copy link

DangerCI commented Jan 7, 2017

Warnings
⚠️ Please add a changelog entry for your changes.

Generated by 🚫 dangerJS

@codecov-io
Copy link

codecov-io commented Jan 7, 2017

Current coverage is 0.00% (diff: 100%)

Merging #90 into master will not change coverage

@@           master   #90   diff @@
===================================
  Files           4     4          
  Lines          35    35          
  Methods         1     1          
  Messages        0     0          
  Branches        7     7          
===================================
  Hits            0     0          
  Misses         35    35          
  Partials        0     0          

Powered by Codecov. Last update 1eac36f...fefbaf4

@orta
Copy link
Member

orta commented Jan 8, 2017

Yes! This was on my TODO for the weekend! Nice one, I kept forgetting to write an issue for this.

@orta orta merged commit e11d898 into danger:master Jan 8, 2017
@kwonoj kwonoj deleted the refacotr-executor branch January 8, 2017 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants