Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support comment editing/deleting for Github Actions #935

Merged

Conversation

jmenestr
Copy link
Contributor

This PR removes the hardcoded userid for Github Actions workflows.

This hard coded value was causing the function

 getDangerCommentIDs = async (dangerID: string): Promise<string[]> => {
    const userID = await this.getUserID()
...
    return allComments
...
      .filter(comment => comment.user.id === userID) // Does it have the right user ID?
...
  }

to always fail because the hard coded userid would NEVER match a comment user id because it was not grabbing the correct userid associated with the given api key.

@orta
Copy link
Member

orta commented Oct 26, 2019

Ah, I bet during the alpha there was a consistent user id for all actions and then that changed.

@orta orta merged commit 470aa91 into danger:master Oct 26, 2019
@peril-staging
Copy link
Contributor

peril-staging bot commented Nov 4, 2019

Thanks for the PR @jmenestr.

This PR has been shipped in v9.2.3 - CHANGELOG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants