Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use node 12 in Dockerfile #937

Merged
merged 1 commit into from Oct 28, 2019
Merged

fix: use node 12 in Dockerfile #937

merged 1 commit into from Oct 28, 2019

Conversation

SimenB
Copy link
Contributor

@SimenB SimenB commented Oct 28, 2019 •
edited

12 is LTS: https://nodejs.org/en/blog/release/v12.13.0/

any chance of a prebuilt image btw? building the entire danger every time is pretty inefficient

@orta
Copy link
Member

orta commented Oct 28, 2019

Cool, yeah, I'm open to it - ideally some kind of GitHub action can upload the image to GPR after a tag ( maybe https://github.com/elgohr/Publish-Docker-Github-Action )

@orta orta merged commit 97ba9e5 into danger:master Oct 28, 2019
@SimenB SimenB deleted the patch-1 branch October 29, 2019 11:25
@peril-staging
Copy link
Contributor

peril-staging bot commented Nov 4, 2019

Thanks for the PR @SimenB.

This PR has been shipped in v9.2.3 - CHANGELOG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SimenB @orta