Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cirrus CI support #956

Merged
merged 4 commits into from Nov 11, 2019
Merged

Add Cirrus CI support #956

merged 4 commits into from Nov 11, 2019

Conversation

RDIL
Copy link
Member

@RDIL RDIL commented Nov 9, 2019

The real challenge is to see if fkorotkov and his mighty search bar find this PR ;)

If you do see this Fedor, hey 馃憢

@RDIL RDIL requested a review from orta November 9, 2019 03:39
@RDIL RDIL assigned orta Nov 9, 2019
@orta
Copy link
Member

orta commented Nov 9, 2019

Looks good to me - but without this sort of documentation people won't know how to use it -

/**
* ### CI Setup
*
* <!-- JS --!>
* You need to edit your `.travis.yml` to include `[run_command]`. If you already have
* a `script:` section then we recommend adding this command at the end of the script step: `- [run_command]`.
*
* Otherwise, add a `before_script` step to the root of the `.travis.yml` with `[run_command]`
*
* ```ruby
* before_script:
* - yarn danger ci
* ```
*
* Adding this to your `.travis.yml` allows Danger to fail your build, both on the TravisCI website and within your Pull Request.
* With that set up, you can edit your job to add `[run_command]` at the build action.
* <!-- !JS --!>
* <!-- Swift --!>
*
* Here's an example of the optimal travis setup, handling caching correctly:
*
* ```yml
* os: osx
* osx_image: xcode10.1
*
* cache:
* directories:
* # General SwiftPM
* # Danger Swift plugins, like Yams
* - .build
* - ~/.danger-swift
*
* install:
* # Grab the latest Danger JS from npm
* - npm install -g danger
* # Compile the Danger runtime
* - swift build
*
* script:
* # Run the Dangerfile.swift
* - swift run danger-swift ci
* # Test my app...
* - [your other commands]
* ```
*
* <!-- !Swift --!>
*
* ### Token Setup
*
* You need to add the `DANGER_GITHUB_API_TOKEN` environment variable, to do this,
* go to your repo's settings, which should look like: `https://travis-ci.org/[user]/[repo]/settings`.
*
* If you have an open source project, you should ensure "Display value in build log" enabled, so that PRs from forks work.
*/

Any chance you can add that?

@RDIL
Copy link
Member Author

RDIL commented Nov 11, 2019

Please re review @orta

@orta
Copy link
Member

orta commented Nov 11, 2019

Ace 馃憤

@orta orta merged commit 0cd4f3a into danger:master Nov 11, 2019
@peril-staging
Copy link
Contributor

peril-staging bot commented Nov 11, 2019

Thanks for the PR @RDIL.

This PR has been shipped in v9.2.5 - CHANGELOG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants