Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitbucket Cloud: Getting UUID from API #964

Merged
merged 6 commits into from
Dec 6, 2019
Merged

Bitbucket Cloud: Getting UUID from API #964

merged 6 commits into from
Dec 6, 2019

Conversation

HelloCore
Copy link
Member

@HelloCore HelloCore commented Dec 6, 2019

From this issue, #856.
I think it's because it's difficult to get correct UUID from Bitbucket Cloud, so having Danger CI get it could be better.
However, we need extra permission (Read Account) to get the UUID.

I think we should not recommend UUID because it's easy to make a mistake (which I've done twice), so I've removed anything related to UUID from the document.

@HelloCore HelloCore requested a review from orta December 6, 2019 17:00
@orta
Copy link
Member

orta commented Dec 6, 2019

Oh great! This looks like I'd expect - thanks @HelloCore :D

@orta orta merged commit 85c686f into danger:master Dec 6, 2019
@peril-staging
Copy link
Contributor

peril-staging bot commented Dec 6, 2019

Thanks for the PR @HelloCore.

This PR has been shipped in v9.2.9 - CHANGELOG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants