Use CI_API_V4_URL in GitLab if it is available #968
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm sure there is lots of room for improvement in this change! Please suggest whatever you think is appropriate. I'm particularly feeling some hnng around the way I'm testing this change.
Basically, since GitLab 11.7 an environment variable called
CI_API_V4_URL
has been available (per https://docs.gitlab.com/ce/ci/variables/predefined_variables.html) which contains the information that we currently supply asDANGER_GITLAB_HOST
.I've left
DANGER_GITLAB_HOST
dominant because some people may have unusual configs where they have done things with hostnames that we don't expect and changing the behaviour may break things for them, but for new users it should now be possible to configure the CI side of Danger by just supplying a token.