Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If no case is matched, use platform name. #984

Merged
merged 1 commit into from
Feb 5, 2020
Merged

If no case is matched, use platform name. #984

merged 1 commit into from
Feb 5, 2020

Conversation

Soyn
Copy link
Member

@Soyn Soyn commented Feb 4, 2020

When i use danger local. The platform name is github cause default case is github. I prefer to use platform name as default case.

@Soyn Soyn requested a review from orta February 4, 2020 14:45
@orta
Copy link
Member

orta commented Feb 4, 2020

I"m a little unsure what this does - how does this affect your usage?

@Soyn
Copy link
Member Author

Soyn commented Feb 5, 2020

When i debug on danger local. The LocalGit platform's name is github. The name is weird. It does not affect any usage.

@orta
Copy link
Member

orta commented Feb 5, 2020

👍 cool

@orta orta merged commit cc03f33 into danger:master Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orta orta Awaiting requested review from orta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Soyn @orta