Add uncommited changeds to LocalGit #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Soyn
commented
Feb 11, 2020
Soyn
commented
- details in danger local should consider uncommitted changes #972
f-meloni
reviewed
Feb 11, 2020
|
Yeah, there should already be a |
Soyn
force-pushed
the
fix/add_uncommitted_changes_to_local
branch
from
ed0352f
to
08be748
Compare
|
I have updated the pull request. |
orta
reviewed
Feb 17, 2020
source/dsl/cli-args.ts
Outdated
| @@ -15,6 +15,8 @@ export interface CliArgs { | |||
| dangerfile: string | |||
| /** So you can have many danger runs in one code review */ | |||
| id: string | |||
| /** Use staged changes */ | |||
| staged?: boolean | |||
There was a problem hiding this comment.
Are you sure this works? The option above is .option("-s, --staging", "Just use staged changes.") - so I'd expect this to be staging?
There was a problem hiding this comment.
In my local test. It works well. I will update the pull request later.
|
Make |
orta
reviewed
Feb 20, 2020
| .option("-b, --base [branch_name]", "Use a different base branch") | ||
| setSharedArgs(program).parse(process.argv) | ||
|
|
||
| const app = (program as any) as App | ||
| const base = app.base || "master" | ||
|
|
||
| const localPlatform = new LocalGit({ base, staged: app.staging }) |
There was a problem hiding this comment.
Oh, this is why it used to work - makes sense
|
Cool beans, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.