Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Danger report results #89

Merged
merged 3 commits into from
Oct 24, 2018
Merged

Expose Danger report results #89

merged 3 commits into from
Oct 24, 2018

Conversation

f-meloni
Copy link
Member

I thought it would be valuable to allow who is writing the Dangerfile to access the current report results.
An example of usage could be the ruby LGTM plugin that uses it to understand if show or not the LGTM image. https://github.com/leonhartX/danger-lgtm/blob/master/lib/lgtm/plugin.rb#L33

@f-meloni f-meloni changed the title Exposed current Danger report results Expose Danger report results Oct 23, 2018
@f-meloni
Copy link
Member Author

I'm not sure of why is not passing the CI.
Looks that is failing on the

DEBUG="*" danger-swift ci

command that was added on the previous PR.
@orta can you please help me to understand what i did wrong? :)
Thank you

@orta
Copy link
Member

orta commented Oct 24, 2018

Weird, the CI says its green but classed as pending, maybe GitHub issues?

@orta
Copy link
Member

orta commented Oct 24, 2018

Anyway, I'm cool with this

@orta orta merged commit cd3d6d9 into danger:master Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants