Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify the GitHub bot requires "Write" access #60

Merged
merged 1 commit into from Jul 28, 2016
Merged

Specify the GitHub bot requires "Write" access #60

merged 1 commit into from Jul 28, 2016

Conversation

epologee
Copy link
Contributor

If set to "Read", the build will fail with a message akin to the following:

Danger has failed this build. 
Found 1 error and I don't have write access to the PR set a PR status.

I do wonder if this is different for OSS projects, and whether getting_started.html.slim:63 should be changed as well:

In order to get the most out of Danger, we recommend giving her the ability to post comments in your code review. This is a regular GitHub account, depending on whether you are working on a private or public project you will want to give different levels of access to this bot. You are allowed to have [one bot per GitHub account][github_bots].

If set to "Read", the build will fail with a message akin to the following:

> Danger has failed this build. 
> Found 1 error and I don't have write access to the PR set a PR status.
@orta
Copy link
Member

orta commented Jul 28, 2016

Thanks - yeah, agree on this.

I think there should probably be something about the fact that the status API is optional, hrm, we should also use it to show a green when she passes too - hadn't thought of that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants