-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] GitHub api request fails when PR diff is > 300 files #1489
Comments
This is how we solved it in danger js, for anyone interested in making a PR: danger/danger-js#1440 |
Did some poking around to see where this change would need to be, and think I narrowed it down to here: danger/lib/danger/request_sources/github/github.rb Lines 79 to 81 in b5e62e8
|
Hi! |
Thanks to @orta and @technicalpickles, I opened a PR with fixes: |
It would be great to have a patch release for this fix, since it breaks our CI pipelines every once in a while. |
I will publish a new release in a couple of days. You may want to use |
Report
What did you do?
We are running a custom danger file on PR diff:
We have started to see failures on CI within the last month or so when running this for PRs that have more than 300 files diff.
Here's the error log:
What did you expect to happen?
Danger runs successfully on PRs with diff of over 300 files.
What happened instead?
Danger fails with error (see above)
Your Environment
Which CI are you running on? - CircleCI
Are you running the latest version of Danger? - Yes, we are on
danger 9.4.3
What is your Dangerfile?
The text was updated successfully, but these errors were encountered: