Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose DangerfileGitLabPlugin#mr_changes #1309

Merged
merged 1 commit into from Jul 1, 2021

Conversation

rymai
Copy link
Contributor

@rymai rymai commented Jul 1, 2021

@orta
Copy link
Member

orta commented Jul 1, 2021

The failure on AppVeyor does look legit:

  1) Danger::DangerfileGitLabPlugin#mr_changes sets the mr_changes
2426     Failure/Error: expect(plugin.mr_changes).to all(be_an_instance_of(Gitlab::ObjectifiedHash))
2427

@rymai
Copy link
Contributor Author

rymai commented Jul 1, 2021

The failure on AppVeyor does look legit:

  1) Danger::DangerfileGitLabPlugin#mr_changes sets the mr_changes
2426     Failure/Error: expect(plugin.mr_changes).to all(be_an_instance_of(Gitlab::ObjectifiedHash))
2427

Hmm, this passes locally. 🤔 Do you know how can I reproduce locally?

Signed-off-by: Rémy Coutable <remy@rymai.me>
@rymai
Copy link
Contributor Author

rymai commented Jul 1, 2021

@orta Ok, I removed the first assertion as this wasn't really needed anyway.

@orta
Copy link
Member

orta commented Jul 1, 2021

Cool beans, will try make a release now

@orta orta merged commit cccc112 into danger:master Jul 1, 2021
@orta
Copy link
Member

orta commented Jul 1, 2021

Shipped in 8.3.1

@rymai rymai deleted the expose-mr_changes branch July 5, 2021 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants