Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't post Dangefile errors as comment on PR when the DANGER_DO_NOT_POST_INVALID_DANGERFILE_ERROR env var is set #1354

Merged
merged 1 commit into from Feb 28, 2022
Merged

Don't post Dangefile errors as comment on PR when the DANGER_DO_NOT_POST_INVALID_DANGERFILE_ERROR env var is set #1354

merged 1 commit into from Feb 28, 2022

Conversation

rymai
Copy link
Contributor

@rymai rymai commented Feb 23, 2022

This addresses #1352.

@rymai rymai added the Bug label Feb 23, 2022
@rymai rymai self-assigned this Feb 23, 2022
@orta
Copy link
Member

orta commented Feb 24, 2022

I'd be open to us filtering the output here with the env vars, I'm not really sold on removing the feature

@rymai
Copy link
Contributor Author

rymai commented Feb 24, 2022

I'd be open to us filtering the output here with the env vars, I'm not really sold on removing the feature

Do you agree it's a non-secure feature based on what's described in #1352?

@rymai
Copy link
Contributor Author

rymai commented Feb 25, 2022 •
edited

I'd be open to us filtering the output here with the env vars

Do you mean merging #1353? I think that would address the main issue for us. 👍 Then I'm ok adding an option to not to print errors as comments in PR/MR, if you'd accept that.

@orta
Copy link
Member

orta commented Feb 25, 2022

Yeah, I agree it could leak - I'm totally fine with having an option to skip the inline error report 👍🏻

@rymai
Don't post Dangefile errors as comment on PR
12e0a49 
Signed-off-by: Rémy Coutable <remy@rymai.me>
@rymai rymai force-pushed the 1352-dont-post-error-as-comment branch from c206224 to 12e0a49 Compare February 28, 2022 11:03
@rymai rymai changed the title Don't post Dangefile errors as comment on PR Don't post Dangefile errors as comment on PR when the DANGER_DO_NOT_POST_INVALID_DANGERFILE_ERROR env var is set Feb 28, 2022
@rymai
Copy link
Contributor Author

rymai commented Feb 28, 2022

@orta Thanks! I changed the PR to not post failure comment when DANGER_DO_NOT_POST_INVALID_DANGERFILE_ERROR is set, and keeps the previous behavior otherwise. WDYT?

@orta
Copy link
Member

orta commented Feb 28, 2022

I think this is a good answer 👍🏻

@orta orta merged commit 89923b3 into danger:master Feb 28, 2022
@rymai rymai deleted the 1352-dont-post-error-as-comment branch March 1, 2022 09:34
@rymai
Copy link
Contributor Author

rymai commented Mar 3, 2022

@orta Would it be possible to have a new 8.4.4. version released with this fix? 🙏

@orta
Copy link
Member

orta commented Mar 3, 2022

Sure

@orta
Copy link
Member

orta commented Mar 3, 2022

Shipped

@manicmaniac manicmaniac mentioned this pull request Jan 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rymai rymai

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rymai @orta