Release to GitHub Container Registry #1445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems reasonable to me 👍🏻 |
|
It seems we're succeeding in publishing the container image (https://github.com/danger/danger/pkgs/container/danger/106254064), but struggle to tag it correctly (https://github.com/danger/danger/actions/runs/5436611587/jobs/9886592800#step:5:686). Investigating & will follow up with another PR. Apologies for the disruption here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[dangergem.slack.com context]
Fixes #1110
This PR adds a workflow similar to danger/swift, danger/kotlin, and danger/danger-js, but has been updated to make use of new
githubcontext variables for easier setup (see https://github.com/docker/build-push-action#usage + https://docs.github.com/en/actions/publishing-packages/publishing-docker-images#publishing-images-to-github-packages). If this PR is accepted, I'd be happy to port these changes to the aforementioned repos.It will publish an image on
ghcr.io/danger/dangeron each new tag (e.g.,ghcr.io/danger/danger:v9.3.1for latest) and on new pushes to the default branch (atghcr.io/danger/danger:master).