Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support a danger local command #40

Merged
merged 13 commits into from
Feb 12, 2016
Merged

Support a danger local command #40

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
fa09e05
Initial work on supporting a `danger local` command
orta Jan 30, 2016
d8d1f2d
Get the git info for the last PR out of the history
orta Jan 30, 2016
7d0b4be
Some rubocop faffing
orta Jan 30, 2016
171293c
Merge branch 'master' into local_test
orta Feb 7, 2016
32bc182
Add a runnable version of danger
orta Feb 7, 2016
6f29ae0
Add support for a verbose mode in the DSL
orta Feb 7, 2016
c132d74
Add specs around verbose
orta Feb 7, 2016
6458ab4
Merge branch 'master' of https://github.com/orta/danger into local_test
orta Feb 8, 2016
95d56c6
Merge branch 'master' of https://github.com/danger/danger into local_…
orta Feb 12, 2016
0719140
Danger Local now works
orta Feb 12, 2016
b730589
Only show base/head when they are needed
orta Feb 12, 2016
456ff79
Use CI for base/head
orta Feb 12, 2016
41a5939
CHANGELOG
orta Feb 12, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/danger.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
require "danger/version"
require "danger/dangerfile"
require "danger/environment_manager"
require "danger/runner"
require "danger/commands/runner"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tried to make this work like cocoapods, but I'm missing something

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CocoaPods shows the sub-commands

~/d/r/l/danger (local_test) ⏛  pod --help
Usage:

    $ pod COMMAND

      CocoaPods, the Cocoa library package manager.

Commands:

    + cache          Manipulate the CocoaPods cache
    + deintegrate    Deintegrate CocoaPods from your project.
    + dependencies   Show project's dependency graph.

Danger doesn't

~/d/r/l/danger (local_test) ⏛  bundle exec danger --help
Usage:

    $ danger COMMAND

      Run the Dangerfile.

Options:

    --version   Show the version of the tool
    --verbose   Show more debugging information

require "danger/init"
require "danger/available_values"

Expand Down
1 change: 1 addition & 0 deletions lib/danger/ci_source/local_git_repo.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
puts "ok"
35 changes: 35 additions & 0 deletions lib/danger/commands/local.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
module Danger
class Local < Runner
self.description = 'Run the Dangerfile locally.'
self.command = 'local'

def initialize(argv)
@dangerfile_path = "Dangerfile" if File.exist? "Dangerfile"
super
end

def validate!
super
unless @dangerfile_path
help! "Could not find a Dangerfile."
end
end

def run
# The order of the following commands is *really* important
dm = Dangerfile.new
dm.env = EnvironmentManager.new(ENV)
dm.env.ci_source =
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace detected.

dm.env.fill_environment_vars
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent the first parameter one step more than the start of the previous line.
Indent the first line of the right-hand-side of a multi-line assignment.

dm.env.scm.diff_for_folder(".", dm.env.ci_source.base_commit, dm.env.ci_source.head_commit)
dm.parse Pathname.new(@dangerfile_path)

post_results(dm)
end

def post_results(dm)
gh = dm.env.request_source
gh.update_pull_request!(warnings: dm.warnings, errors: dm.errors, messages: dm.messages)
end
end
end
0 lib/danger/runner.rb → lib/danger/commands/runner.rb
View file
Open in desktop
File renamed without changes.