Calling CircleCI API when CI_PULL_REQUEST is not set #57
Conversation
| @@ -25,6 +25,7 @@ Gem::Specification.new do |spec| | |||
| spec.add_runtime_dependency 'colored' | |||
| spec.add_runtime_dependency 'nap' | |||
| spec.add_runtime_dependency 'octokit' | |||
| spec.add_runtime_dependency 'rest-client' | |||
There was a problem hiding this comment.
rest client is an extra dependency we don't need, faraday is already in the dependency graph (comes from OckoKit), any chance you can use that? https://github.com/lostisland/faraday
There was a problem hiding this comment.
sure, I'll take a look at that later. I hadn't used rest-client before also, just seen some gem using it and thought it was good enough.
|
Everything feels good in the implementation though! |
|
Travis failed because of CHANGELOG, so #56 really worked! I'm updating it after, so I can update the README at the same time with information about the new parameter. |
|
I don't know if this deserves a mention on README 😁 |
|
I think it's best that we start building out docs, will try take a stab at this in the morning 👍 |
| @@ -20,13 +21,15 @@ def validate! | |||
| def self.options | |||
| [ | |||
| ['--base=[master|dev|stable]', 'A branch/tag/commit to use as the base of the diff'], | |||
| ['--head=[master|dev|stable]', 'A branch/tag/commit to use as the head'] | |||
| ['--head=[master|dev|stable]', 'A branch/tag/commit to use as the head'], | |||
| ['--circle-ci-token=[token]', 'A Circle CI API token to be used if needed'] | |||
There was a problem hiding this comment.
IMO, kill this option, only allow setting this form an env var, otherwise you'd be leaking it in the build logs
marcelofabri
changed the title
|
Yep, yep yep. |
Calling CircleCI API when CI_PULL_REQUEST is not set
|
Thanks sir |
circle-tokenIt should fix #49