Merge pull request #151 from doodeec/bugfix/milestone-closed-state

Fix closed milestone state serialization
danger · Dec 9, 2020 · b891d80 · b891d80
2 parents ef467cf + a89be2a
commit b891d80
Show file tree

Hide file tree

Showing 5 changed files with 2,136 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -17,6 +17,7 @@
 - Road to 1.0 - Refactor project structure [@gianluz] - [#142](https://github.com/danger/kotlin/pull/142)
 - Fix gitlab defaults following kotlinx serialisation [@gianluz] - [#146](https://github.com/danger/kotlin/pull/146)
 - Road to 1.0 - Migrate from java.util.Date to kotlinx.datetime [@gianluz] - [#147](https://github.com/danger/kotlin/pull/147)
+- Fix typo in Github Milestone serialization [@doodeec] - [#151](https://github.com/danger/kotlin/pull/151)
 
 # 0.7.1
 

diff --git a/danger-kotlin-library/src/main/kotlin/systems/danger/kotlin/models/github/GitHub.kt b/danger-kotlin-library/src/main/kotlin/systems/danger/kotlin/models/github/GitHub.kt
@@ -302,8 +302,8 @@ data class GitHubUser(
 
 @Serializable
 enum class GitHubMilestoneState {
-    @SerialName("close")
-    CLOSE,
+    @SerialName("closed")
+    CLOSED,
 
     @SerialName("open")
     OPEN,

diff --git a/...-kotlin-library/src/test/kotlin/systems/danger/kotlin/models/github/GitHubParsingTests.kt b/...-kotlin-library/src/test/kotlin/systems/danger/kotlin/models/github/GitHubParsingTests.kt
@@ -210,6 +210,19 @@ class GitHubParsingTests {
         }
     }
 
+    @Test
+    fun testItParsesTheClosedMilestone() {
+        val dsl: DSL = Json {
+            ignoreUnknownKeys = true
+            isLenient = true
+        }.decodeFromString(JSONFiles.githubWithClosedMilestoneDangerJSON)
+        val github = dsl.danger.github
+
+        with(github.issue.milestone!!) {
+            assertEquals(GitHubMilestoneState.CLOSED, state)
+        }
+    }
+
     @Test
     fun testOnGitHubIsTrue() {
         assertEquals(true, dsl.danger.onGitHub)

diff --git a/danger-kotlin-library/src/test/kotlin/systems/danger/kotlin/utils/TestUtils.kt b/danger-kotlin-library/src/test/kotlin/systems/danger/kotlin/utils/TestUtils.kt
@@ -19,6 +19,11 @@ object TestUtils {
         val githubWithSomeNullsAttributeDangerJSON by lazy {
             loadJSON("githubWithSomeNullsAttributeDangerJSON.json")
         }
+
+        val githubWithClosedMilestoneDangerJSON by lazy {
+            loadJSON("githubWithClosedMilestoneDangerJSON.json")
+        }
+
         val dangerBitBucketServerJSON by lazy {
             loadJSON("bitbucketServerDangerJSON.json")
         }