Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix closed milestone state serialization #151

Merged
merged 2 commits into from
Dec 9, 2020
Merged

Fix closed milestone state serialization #151

merged 2 commits into from
Dec 9, 2020

Conversation

doodeec
Copy link

@doodeec doodeec commented Dec 9, 2020 •
edited

Typo in the Github Milestone serialization caused failure when PR is assigned to a closed Milestone
fixes #150

f-meloni
f-meloni approved these changes Dec 9, 2020
View reviewed changes
Copy link
Member

@f-meloni f-meloni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@danger-public
Copy link

danger-public commented Dec 9, 2020 •
edited

Warnings
⚠️ Big PR, try to keep changes smaller if you can

Generated by 🚫 Danger Kotlin against a89be2a

@f-meloni f-meloni merged commit b891d80 into danger:master Dec 9, 2020
@doodeec doodeec deleted the bugfix/milestone-closed-state branch December 9, 2020 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f-meloni f-meloni f-meloni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Danger execution fails for PR assigned to a closed milestone
3 participants
@doodeec @danger-public @f-meloni