Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix closed milestone state serialization #151

Merged
merged 2 commits into from
Dec 9, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -302,8 +302,8 @@ data class GitHubUser(

@Serializable
enum class GitHubMilestoneState {
@SerialName("close")
CLOSE,
@SerialName("closed")
CLOSED,

@SerialName("open")
OPEN,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,19 @@ class GitHubParsingTests {
}
}

@Test
fun testItParsesTheClosedMilestone() {
val dsl: DSL = Json {
ignoreUnknownKeys = true
isLenient = true
}.decodeFromString(JSONFiles.githubWithClosedMilestoneDangerJSON)
val github = dsl.danger.github

with(github.issue.milestone!!) {
assertEquals(GitHubMilestoneState.CLOSED, state)
}
}

@Test
fun testOnGitHubIsTrue() {
assertEquals(true, dsl.danger.onGitHub)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@ object TestUtils {
val githubWithSomeNullsAttributeDangerJSON by lazy {
loadJSON("githubWithSomeNullsAttributeDangerJSON.json")
}

val githubWithClosedMilestoneDangerJSON by lazy {
loadJSON("githubWithClosedMilestoneDangerJSON.json")
}

val dangerBitBucketServerJSON by lazy {
loadJSON("bitbucketServerDangerJSON.json")
}
Expand Down
Loading