fix passing peril instance to inline runner #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieh
commented
Oct 5, 2020
Comment on lines
-105
to
+114
| if (dangerRuntimeEnv.sandbox) { | ||
| // Mutates runtimeEnv.sandbox | ||
| await appendPerilContextToDSL(installationRun.iID, undefined, dangerRuntimeEnv.sandbox, peril) | ||
| if (dangerRuntimeEnv) { | ||
| // Mutates runtimeEnv | ||
| await appendPerilContextToDSL(installationRun.iID, undefined, dangerRuntimeEnv, peril) |
There was a problem hiding this comment.
This is actual fix - rest of the PR is either forced prettier re-formatting or very minor (not critical) adjustments
There was a problem hiding this comment.
It's fine, you can add the param ?w=1 to the PR to get whitespace changes removed from the diff, which made it easier to review
pieh
commented
Oct 5, 2020
| @@ -107,8 +107,7 @@ export async function appendPerilContextToDSL( | |||
| sandbox.danger.github.utils = recreateGitHubUtils(api) | |||
| } | |||
|
|
|||
| const anySandbox = sandbox as any | |||
| anySandbox.peril = peril | |||
| sandbox.peril = peril | |||
There was a problem hiding this comment.
changes in this file are not critical - I should be able revert them without any problems if desired (to keep PR a bit leaner)
|
Cool, yeah, looks good to me 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to fix the logic around appending "Peril context" before executing inline runner. Current logic checks for
sandboxproperty but this is never set, so appending peril context is never executed.From user perspective - this should fix accessing environment variables via
peril.env.*, which is currently not working (perilobjects is just{}, it doesn't even have.envfield)Closes #474