Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept dangerfile parameter on edit command #189

Merged
merged 3 commits into from
Feb 9, 2019
Merged

Conversation

f-meloni
Copy link
Member

@f-meloni f-meloni commented Feb 9, 2019

No description provided.

@f-meloni
Copy link
Member Author

f-meloni commented Feb 9, 2019

merge on green

@@ -0,0 +1 @@

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ File shouldn't start with whitespace: currently starts with 1 whitespace characters (leading_whitespace)

@peril-staging peril-staging bot merged commit 35c672e into master Feb 9, 2019
@peril-staging
Copy link
Contributor

peril-staging bot commented Feb 9, 2019

Danger run resulted in 1 fail and 1 markdown; to find out more, see the checks page.

Generated by 🚫 dangerJS against c0b54d6

@f-meloni
Copy link
Member Author

f-meloni commented Feb 9, 2019

Today peril is angry with me :(

@f-meloni f-meloni deleted the edit_dangerfile branch February 9, 2019 20:03
@orta
Copy link
Member

orta commented Feb 9, 2019

oh yeah, that's a bug

@orta
Copy link
Member

orta commented Feb 9, 2019

fixed danger/peril-settings@9d173f6

@f-meloni
Copy link
Member Author

f-meloni commented Feb 9, 2019

Thanks 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants