Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set github as var to make danger compile with swift 5 #191

Merged
merged 2 commits into from
Feb 10, 2019
Merged

Set github as var to make danger compile with swift 5 #191

merged 2 commits into from
Feb 10, 2019

Conversation

f-meloni
Copy link
Member

Given we set github.api here https://github.com/danger/swift/blob/master/Sources/Danger/DangerDSL.swift#L61 on Swift 5 is required for github to be a var

@f-meloni
Copy link
Member Author

merge on green

@peril-staging peril-staging bot merged commit 4463b6d into master Feb 10, 2019
@peril-staging
Copy link
Contributor

peril-staging bot commented Feb 10, 2019

Danger run resulted in 1 fail and 1 markdown; to find out more, see the checks page.

Generated by 🚫 dangerJS against 88c2f22

@f-meloni
Copy link
Member Author

@orta peril is still complaining :(

@f-meloni f-meloni deleted the build_with_swift_5 branch February 10, 2019 18:39
@orta
Copy link
Member

orta commented Feb 10, 2019

no worries, it'll probably happen a few times - the latest Peril runtime was a big change

@f-meloni
Copy link
Member Author

👍

@f-meloni f-meloni mentioned this pull request Apr 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Merge On Green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@f-meloni @orta