Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code to fix SwiftLint warnings #196

Merged
merged 2 commits into from Feb 17, 2019

Conversation

Projects
None yet
3 participants
@ChaosCoder
Copy link
Member

ChaosCoder commented Feb 16, 2019

This PR is a follow-up to #195. This makes the code more readable, fixes swiftlint warnings introduced by #195 and reverts some whitespace changes #195 introduced.

There should be no changes in behaviour.

@DangerCI

This comment has been minimized.

Copy link

DangerCI commented Feb 16, 2019

Warnings
⚠️

Any changes to library code should be reflected in the Changelog.

Please consider adding a note there and adhere to the Changelog Guidelines.

Generated by 🚫 Danger Swift against 3370189

}

return violations
}

private static func lintAll(directory: String?,
arguments: inout [String],

This comment has been minimized.

@f-meloni

f-meloni Feb 16, 2019

Member

Why do you need arguments to be inout?
You can make arguments a var inside the function, given you don't need the updated value back

This comment has been minimized.

@ChaosCoder

ChaosCoder Feb 17, 2019

Author Member

You are absolutely right. Thank you for spotting this Xcode "extract method" relic. :)

@f-meloni

This comment has been minimized.

Copy link
Member

f-meloni commented Feb 16, 2019

can you please fix or add a swiftlint:disable to Sources/Danger/Plugins/SwiftLint/SwiftLint.swift#L125? Thank you :)

@f-meloni
Copy link
Member

f-meloni left a comment

💯

@f-meloni f-meloni merged commit dbdd8cc into danger:master Feb 17, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@peril-staging

This comment has been minimized.

Copy link
Contributor

peril-staging bot commented Feb 24, 2019

Thanks for the PR @ChaosCoder.

This PR has been shipped in v1.4.0 - CHANGELOG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.