Refactor code to fix SwiftLint warnings #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Swift against 3370189 |
f-meloni
reviewed
Feb 16, 2019
| } | ||
|
|
||
| return violations | ||
| } | ||
|
|
||
| private static func lintAll(directory: String?, | ||
| arguments: inout [String], |
There was a problem hiding this comment.
Why do you need arguments to be inout?
You can make arguments a var inside the function, given you don't need the updated value back
There was a problem hiding this comment.
You are absolutely right. Thank you for spotting this Xcode "extract method" relic. :)
|
can you please fix or add a swiftlint:disable to |
|
Thanks for the PR @ChaosCoder. This PR has been shipped in v1.4.0 - CHANGELOG. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #195. This makes the code more readable, fixes swiftlint warnings introduced by #195 and reverts some whitespace changes #195 introduced.
There should be no changes in behaviour.