Add ability to run swiftlint in strict mode #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Swift against dfc83d3 |
f-meloni
reviewed
Feb 15, 2019
| violation.update(file: updatedPath) | ||
| violation.file = updatedPath | ||
| if strict { | ||
| violation.severity = .error |
There was a problem hiding this comment.
can you please add a specific test for this? This would (I think), also change how the violation gets displayed on the markdown table, in that case that should be tested as well 👍
|
Thanks for the PR @FabioTacke. This PR has been shipped in v1.4.0 - CHANGELOG. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a strict mode that treats warnings like errors in inline mode, i.e. fails the build when a warning occurrs.