Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom danger-js path #206

Merged
merged 1 commit into from Mar 5, 2019

Conversation

Projects
None yet
3 participants
@f-meloni
Copy link
Member

f-meloni commented Mar 5, 2019

It would be cool to allow people to embed a compiled danger-js in their repo if they want

@f-meloni

This comment has been minimized.

Copy link
Member Author

f-meloni commented Mar 5, 2019

merge on green

import Logger
import ShellOut

public func getDangerCommandPath(logger: Logger, args: [String] = CommandLine.arguments, shellOutExecutor: ShellOutExecuting = ShellOutExecutor()) throws -> String {

This comment has been minimized.

@DangerCI

DangerCI Mar 5, 2019

  • ⚠️ Line should be 120 characters or less: currently 165 characters (line_length)
@DangerCI

This comment has been minimized.

Copy link

DangerCI commented Mar 5, 2019

Warnings
⚠️

Any changes to library code should be reflected in the Changelog.

Please consider adding a note there and adhere to the Changelog Guidelines.

Generated by 🚫 Danger Swift against 0bbefb9

@peril-staging peril-staging bot merged commit d264253 into master Mar 5, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@f-meloni f-meloni deleted the danger_js_path branch Mar 5, 2019

@orta

This comment has been minimized.

Copy link
Member

orta commented Mar 5, 2019

This has no docs ^

@f-meloni

This comment has been minimized.

Copy link
Member Author

f-meloni commented Mar 5, 2019

Yep, will add it in an additional PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.