Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial support to swift 5.0 #210

Merged
merged 5 commits into from
Mar 22, 2019
Merged

Initial support to swift 5.0 #210

merged 5 commits into from
Mar 22, 2019

Conversation

f-meloni
Copy link
Member

No description provided.

@f-meloni f-meloni marked this pull request as ready for review March 12, 2019 23:33
@orta
Copy link
Member

orta commented Mar 12, 2019

cool

DangerCI
DangerCI reviewed Mar 13, 2019
View reviewed changes
Sources/RunnerLib/Files Import/DangerFileGenerator.swift
@@ -11,7 +11,7 @@ public final class DangerFileGenerator {
importsRegex.enumerateMatches(in: content, options: [], range: NSRange(location: 0, length: content.count), using: { result, _, _ in
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ Line should be 120 characters or less: currently 140 characters (line_length)

@f-meloni
Copy link
Member Author

f-meloni commented Mar 13, 2019 •
edited
Loading

On Linux looks not working :( not sure if is related to the dev snapshot I'm using or is a swift 5.0 bug

@f-meloni
Copy link
Member Author 

Stack dump:
0.	Program arguments: /home/travis/.swiftenv/versions/5.0-DEVELOPMENT-SNAPSHOT-2019-03-06-a/usr/bin/swift -frontend -interpret /tmp/_tmp_dangerfile.swift -disable-objc-interop -I .build/debug -module-name _tmp_dangerfile -lDangerDeps -- /tmp/danger-dsl.json /tmp/danger-response.json 
#0 0x0000000004293db4 PrintStackTraceSignalHandler(void*) (/home/travis/.swiftenv/versions/5.0-DEVELOPMENT-SNAPSHOT-2019-03-06-a/usr/bin/swift+0x4293db4)
#1 0x0000000004291f10 llvm::sys::RunSignalHandlers() (/home/travis/.swiftenv/versions/5.0-DEVELOPMENT-SNAPSHOT-2019-03-06-a/usr/bin/swift+0x4291f10)
#2 0x0000000004294118 SignalHandler(int) (/home/travis/.swiftenv/versions/5.0-DEVELOPMENT-SNAPSHOT-2019-03-06-a/usr/bin/swift+0x4294118)
#3 0x00007ff70fe16330 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x10330)
#4 0x00007ff70c0fd074
#5 0x0000000000c98fa6 llvm::MCJIT::runFunction(llvm::Function*, llvm::ArrayRef<llvm::GenericValue>) (/home/travis/.swiftenv/versions/5.0-DEVELOPMENT-SNAPSHOT-2019-03-06-a/usr/bin/swift+0xc98fa6)
#6 
0x0000000000c9cf9f llvm::ExecutionEngine::runFunctionAsMain(llvm::Function*, std::vector<std::string, std::allocator<std::string> > const&, char const* const*) (/home/travis/.swiftenv/versions/5.0-DEVELOPMENT-SNAPSHOT-2019-03-06-a/usr/bin/swift+0xc9cf9f)
#7 0x000000000050a507 swift::RunImmediately(swift::CompilerInstance&, std::vector<std::string, std::allocator<std::string> > const&, swift::IRGenOptions&, swift::SILOptions const&) (/home/travis/.swiftenv/versions/5.0-DEVELOPMENT-SNAPSHOT-2019-03-06-a/usr/bin/swift+0x50a507)
#8 0x00000000004e1587 performCompile(swift::CompilerInstance&, swift::CompilerInvocation&, llvm::ArrayRef<char const*>, int&, swift::FrontendObserver*, swift::UnifiedStatsReporter*) (/home/travis/.swiftenv/versions/5.0-DEVELOPMENT-SNAPSHOT-2019-03-06-a/usr/bin/swift+0x4e1587)
#9 0x00000000004dc917 swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) (/home/travis/.swiftenv/versions/5.0-DEVELOPMENT-SNAPSHOT-2019-03-06-a/usr/bin/swift+0x4dc917)
#10 0x000000000048dd93 main (/home/travis/.swiftenv/versions/5.0-DEVELOPMENT-SNAPSHOT-2019-03-06-a/usr/bin/swift+0x48dd93)
#11 0x00007ff70e5e3f45 __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21f45)
#12 0x000000000048bfe8 _start (/home/travis/.swiftenv/versions/5.0-DEVELOPMENT-SNAPSHOT-2019-03-06-a/usr/bin/swift+0x48bfe8)

@f-meloni
Copy link
Member Author

I will open another issue for the problem on Linux, because I don't know how to fix it yet, in them meantime will merge it because at least works on OSX

@f-meloni
Copy link
Member Author

merge on green

@f-meloni
Copy link
Member Author

peril? :(
merge on green

@f-meloni
Copy link
Member Author

nothing :(

@f-meloni
Copy link
Member Author

Ok worked :P

@peril-staging peril-staging bot merged commit 0456d98 into master Mar 22, 2019
@orta
Copy link
Member

orta commented Mar 23, 2019

:D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DangerCI DangerCI DangerCI left review comments

Assignees
No one assigned
Labels
Merge On Green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@f-meloni @orta @DangerCI