Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support danger swift options and don't pass them to danger ci #215

Merged
merged 3 commits into from Mar 26, 2019

Conversation

Projects
None yet
2 participants
@f-meloni
Copy link
Member

commented Mar 26, 2019

I discovered that we can not pass unknown option to danger-js ci but we can on danger-js pr (this is why when I tested the --danger-js-path change was working 🤷🏻‍♂️
Anyway this change opens also to a future help with the supported danger-swift options that will be merged with the supported options of danger-js as discussed @orta

@@ -3,7 +3,7 @@ import Logger
import ShellOut

public func getDangerCommandPath(logger: Logger, args: [String] = CommandLine.arguments, shellOutExecutor: ShellOutExecuting = ShellOutExecutor()) throws -> String {

This comment has been minimized.

Copy link
@DangerCI

DangerCI Mar 26, 2019

  • ⚠️ Line should be 120 characters or less: currently 165 characters (line_length)

f-meloni added some commits Mar 26, 2019

@f-meloni

This comment has been minimized.

Copy link
Member Author

commented Mar 26, 2019

merge on green

@peril-staging peril-staging bot merged commit e156cea into master Mar 26, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.