Support danger swift options and don't pass them to danger ci #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DangerCI
reviewed
Mar 26, 2019
| @@ -3,7 +3,7 @@ import Logger | |||
| import ShellOut | |||
|
|
|||
| public func getDangerCommandPath(logger: Logger, args: [String] = CommandLine.arguments, shellOutExecutor: ShellOutExecuting = ShellOutExecutor()) throws -> String { | |||
There was a problem hiding this comment.
⚠️ Line should be 120 characters or less: currently 165 characters (line_length)
|
merge on green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered that we can not pass unknown option to
danger-js cibut we can ondanger-js pr(this is why when I tested the--danger-js-pathchange was working 🤷🏻♂️Anyway this change opens also to a future help with the supported danger-swift options that will be merged with the supported options of
danger-jsas discussed @orta