Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove not needed coding keys #233

Merged
merged 2 commits into from
May 12, 2019
Merged

Remove not needed coding keys #233

merged 2 commits into from
May 12, 2019

Conversation

f-meloni
Copy link
Member

No description provided.

@f-meloni
Copy link
Member Author

merge on green

DangerCI
DangerCI reviewed May 12, 2019
View reviewed changes
Sources/Danger/GitHubDSL.swift
}

// MARK: - Properties

/// The UUID for the team.
public let id: Int
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ Variable name should be between 3 and 40 characters long: 'id' (identifier_name)

@DangerCI
Copy link

Warnings
⚠️

Sources/Danger/GitHubDSL.swift#L154 - Enum element name should be between 3 and 40 characters long: 'id' (identifier_name)
⚠️

Sources/Danger/GitHubDSL.swift#L169 - Variable name should be between 3 and 40 characters long: 'id' (identifier_name)
⚠️

Sources/Danger/GitHubDSL.swift#L226 - Enum element name should be between 3 and 40 characters long: 'id' (identifier_name)
⚠️

Sources/Danger/GitHubDSL.swift#L239 - Variable name should be between 3 and 40 characters long: 'id' (identifier_name)
⚠️

Sources/Danger/GitHubDSL.swift#L270 - Enum element name should be between 3 and 40 characters long: 'id' (identifier_name)
⚠️

Sources/Danger/GitHubDSL.swift#L290 - Variable name should be between 3 and 40 characters long: 'id' (identifier_name)
⚠️

Sources/Danger/GitHubDSL.swift#L330 - Enum element name should be between 3 and 40 characters long: 'id' (identifier_name)
⚠️

Sources/Danger/GitHubDSL.swift#L358 - Variable name should be between 3 and 40 characters long: 'id' (identifier_name)
⚠️

Sources/Danger/GitHubDSL.swift#L409 - Variable name should be between 3 and 40 characters long: 'id' (identifier_name)
⚠️

Sources/Danger/GitHubDSL.swift#L433 - Enum element name should be between 3 and 40 characters long: 'id' (identifier_name)
⚠️

Sources/Danger/GitHubDSL.swift#L452 - Variable name should be between 3 and 40 characters long: 'id' (identifier_name)
⚠️

Sources/Danger/GitHubDSL.swift#L486 - File should contain 400 lines or less: currently contains 486 (file_length)

Generated by 🚫 Danger Swift against 694594e

@peril-staging peril-staging bot merged commit 22299bf into master May 12, 2019
@f-meloni f-meloni deleted the coding_keys branch May 12, 2019 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DangerCI DangerCI DangerCI left review comments

Assignees
No one assigned
Labels
Merge On Green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@f-meloni @DangerCI