Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove not needed coding keys #233

Merged
merged 2 commits into from
May 12, 2019
Merged

Remove not needed coding keys #233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5d274c
Remove not needed coding keys
f-meloni May 12, 2019
694594e
Updated CHANGELOG
f-meloni May 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

## Master

- Remove not needed coding keys [@f-meloni][] - [#233](https://github.com/danger/swift/pull/233)
- Re use the same executor on the runner [@f-meloni][] - [#230](https://github.com/danger/swift/pull/230)

## 1.5.4
Expand Down
20 changes: 0 additions & 20 deletions Sources/Danger/GitHubDSL.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,15 +179,6 @@ public struct GitHubUser: Decodable, Equatable {

/// A GitHub team.
public struct GitHubTeam: Decodable, Equatable {
// MARK: - CodingKeys

enum CodingKeys: String, CodingKey {
case id
case name
}

// MARK: - Properties

/// The UUID for the team.
public let id: Int
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ Variable name should be between 3 and 40 characters long: 'id' (identifier_name)


Expand All @@ -199,15 +190,6 @@ public struct GitHubTeam: Decodable, Equatable {

/// Represents the payload for a PR's requested reviewers value.
public struct GitHubRequestedReviewers: Decodable, Equatable {
// MARK: - CodingKeys

enum CodingKeys: String, CodingKey {
case users
case teams
}

// MARK: - Properties

/// The list of users of whom a review has been requested.
public let users: [GitHubUser]

Expand All @@ -219,8 +201,6 @@ public struct GitHubRequestedReviewers: Decodable, Equatable {

/// Represents 'head' in PR
public struct GitHubMergeRef: Decodable, Equatable {
// MARK: - Properties

/// The human display name for the merge reference, e.g. "artsy:master".
public let label: String

Expand Down